[beta] Fail gracefully when encountering an HRTB in APIT. #98462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
|
rust-highfive
added
the
S-waiting-on-review
|
LGTM. @pietroalbini Not sure if you would prefer to pull this in with the beta promotion? Or just go ahead and merge it now? |
Mark-Simulacrum
changed the title
|
@bors r+ rollup=never p=5 |
|
📌 Commit a081507 has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit a081507 with merge b6ee5a350bc7576847e18b242440ac813c05c651... |
|
💥 Test timed out |
bors
added
S-waiting-on-review
|
@bors retry |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #97683
The diagnostic is a bit worse, but still better than an ICE.
r? @ehuss